Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete stale Cruise Control API users #10787

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Delete stale Cruise Control API users #10787

merged 1 commit into from
Nov 1, 2024

Conversation

kyguy
Copy link
Member

@kyguy kyguy commented Oct 30, 2024 •
edited
Loading

Type of change

  • Bugfix

Description

Addresses #10649

There is a bug in the Cruise Control integration code that prevents stale API users from past user-managed API secrets from being deleted. The bug makes it impossible to update the passwords and roles of usernames that had been used by past user-managed secrets without manually deleting the Cruise Control API secret.

This PR ensures that the API users added to the Cruise Control API secret from past user-managed API secrets are removed at reconciliation. It also fixes a typo in the documentation for enabling CC API users

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@kyguy
Delete stale CC API users
a9ccb6d 
Signed-off-by: Kyle Liberti <[email protected]>
@kyguy kyguy added this to the 0.45.0 milestone Oct 30, 2024
@kyguy kyguy marked this pull request as ready for review October 31, 2024 00:19
@scholzj scholzj linked an issue Oct 31, 2024 that may be closed by this pull request
[Bug]: Do reconciliation and rolling update on pod (Cruise Control) even if only secretKeyRef changed #10649
Closed
scholzj
scholzj approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into this.

@scholzj
Copy link
Member

scholzj commented Oct 31, 2024

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

katheris
katheris approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppatierno
ppatierno approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit eec6d1e into strimzi:main Nov 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaselenge tinaselenge tinaselenge approved these changes

@katheris katheris katheris approved these changes

@ppatierno ppatierno ppatierno approved these changes

@scholzj scholzj scholzj approved these changes

@ShubhamRwt ShubhamRwt Awaiting requested review from ShubhamRwt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Do reconciliation and rolling update on pod (Cruise Control) even if only secretKeyRef changed
5 participants
@kyguy @scholzj @ppatierno @katheris @tinaselenge